New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.01] Trackster fixes. #5261

Merged
merged 24 commits into from Mar 8, 2018

Conversation

Projects
None yet
3 participants
@dannon
Member

dannon commented Jan 3, 2018

This makes the Trackster work again.

The gist here is a reasonably large viz overhaul with the goals of 1) making it work again, and 2) converting the whole thing to classes and modern javascript inheritance.

Implementing ES6 multiple inheritance w/ backbone objects/etc. turned out to be more of a pain than I expected, so I pulled those changes into another branch to keep working on in order to get the core fixes into 18.01.

dannon added some commits Dec 21, 2017

Disentangle 'view' handling in trackster track initialization. This i…
…s a step towards making Trackster work again.
Fix undefined var in trackster/filters -- still exists one that I nee…
…d to fix here, but that'll take some digging.
More trackster/tracks work. More variable scoping issues fixed, funct…
…ion definitions standardized. One callback issue resolved.
Rewrite painters using ES6 classes, for my sanity and future maintena…
…nce. Still won't paint, but it's easier to track through the hierarchy now.
Trackster refactoring; this pulls apart using a global view. There is a
trackster ui, which holds the main view, and should be accessed through
it when necessary.
@martenson

This comment has been minimized.

Member

martenson commented Jan 25, 2018

We have branched the 18.01, if this wants to make it there, it needs to re-target to that branch.

@dannon

This comment has been minimized.

Member

dannon commented Jan 25, 2018

It's a bunch of bugfixes; definitely needs to be 18.01; retargeting.

@dannon dannon changed the base branch from dev to release_18.01 Jan 25, 2018

@martenson martenson changed the title from WIP, Trackster fixes. to [18.01] WIP, Trackster fixes. Feb 1, 2018

dannon added some commits Mar 5, 2018

Fix config parameter default building in tracks.js; ideally this turn…
…s into classes when the multiple inheritance is fixed/refactored, and we can use simple static getter/setter methods.

@dannon dannon changed the title from [18.01] WIP, Trackster fixes. to [18.01] Trackster fixes. Mar 6, 2018

@dannon dannon added status/review and removed status/WIP labels Mar 6, 2018

@dannon

This comment has been minimized.

Member

dannon commented Mar 6, 2018

Basic local testing passes for me now; I can display and browse, change modes, etc.

@jmchilton jmchilton merged commit fa3ec5f into galaxyproject:release_18.01 Mar 8, 2018

4 of 6 checks passed

api test Test started.
Details
framework test Test started.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
integration test Build finished. 79 tests run, 4 skipped, 0 failed.
Details
selenium test Build finished. 118 tests run, 2 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
@jmchilton

This comment has been minimized.

Member

jmchilton commented Mar 8, 2018

Thanks @dannon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment