New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset Error Interface Cleanup #5279

Merged
merged 4 commits into from Jan 9, 2018

Conversation

Projects
None yet
2 participants
@dannon
Member

dannon commented Jan 8, 2018

Fat arrow functions, escaping of dataset error output, minor other cleanup.

(will be converted to a Vue interface, but one step at a time -- I'd like to get these changes into 18.01 prior to larger changes in dev)

@dannon dannon added the status/WIP label Jan 8, 2018

@dannon

This comment has been minimized.

Member

dannon commented Jan 8, 2018

Included a client build but I'm happy to rip that changeset back out. It's more convenient for some people, less for others -- just let me know. We've merged #5128, but I'm thinking we'll stop 'officially' committing artifacts post-18.01-branch.

@dannon dannon added this to the 18.01 milestone Jan 8, 2018

@dannon

This comment has been minimized.

Member

dannon commented Jan 9, 2018

The test failure here was due to the flaky test recently decorated in #5286.

@martenson martenson merged commit 11f434a into galaxyproject:dev Jan 9, 2018

5 of 6 checks passed

api test Build finished. 343 tests run, 4 skipped, 1 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 167 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 67 tests run, 0 skipped, 0 failed.
Details
selenium test Build finished. 118 tests run, 2 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment