New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark rerun_with_use_cached_job as flakey #5286

Merged
merged 1 commit into from Jan 9, 2018

Conversation

Projects
None yet
5 participants
@mvdbeek
Member

mvdbeek commented Jan 9, 2018

Sometimes it does not pick up the equivalent job that should exist. Will need
to dig into this, but in the meantime we can allow the test to fail.

Mark rerun_with_use_cached_job as flakey
Sometimes it does not pick up the equivalent job that should exist. Will need
to dig into this, but in the meantime we can allow the test to fail.
@dannon

This comment has been minimized.

Member

dannon commented Jan 9, 2018

@mvdbeek Thanks! I was just looking at this in a few recent test runs.

@galaxybot galaxybot added this to the 18.01 milestone Jan 9, 2018

@dannon dannon merged commit 14cb52e into galaxyproject:dev Jan 9, 2018

6 checks passed

api test Build finished. 343 tests run, 5 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 167 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 67 tests run, 0 skipped, 0 failed.
Details
selenium test Build finished. 118 tests run, 2 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
@nsoranzo

This comment has been minimized.

Member

nsoranzo commented Jan 17, 2018

@mvdbeek @martenson
It seems that @flakey is preventing the build failure only for the selenium tests, see e.g. https://jenkins.galaxyproject.org/job/docker-api/10167/ . Should we add --skip_flakey_fails to the ./run_tests.sh -api invocation in our Jenkins setup?

@martenson

This comment has been minimized.

Member

martenson commented Jan 17, 2018

@nsoranzo I think so, or we can add it to https://github.com/galaxyproject/galaxy/blob/dev/.ci/jenkins/api/run_tests.sh and invoke that instead (dunno why we invoke it manually in the jenkins config, probably remnant)

@mvdbeek

This comment has been minimized.

Member

mvdbeek commented Jan 17, 2018

@nsoranzo That was the intention indeed, thanks for looking into this!

@martenson

This comment has been minimized.

Member

martenson commented Jan 17, 2018

@nsoranzo @mvdbeek for now I have added --skip_flakey_fails to the invocation on jenkins

@martenson

This comment has been minimized.

Member

martenson commented Jan 17, 2018

I have removed that flag, since it breaks all branches older than dev :/

(so we should do the proper solution and invoke jenkins form the (to be updated) .ci/jenkins script)

nsoranzo added a commit to nsoranzo/galaxy that referenced this pull request Jan 25, 2018

jmchilton added a commit to jmchilton/galaxy that referenced this pull request Feb 3, 2018

@mvdbeek mvdbeek deleted the mvdbeek:disable_cached_job_rerun_test branch Jun 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment