New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the migration message when having to downgrade the database #5299

Merged
merged 2 commits into from Jan 11, 2018

Conversation

Projects
None yet
4 participants
@mvdbeek
Member

mvdbeek commented Jan 11, 2018

That should make more sense than sh_manage_db.sh upgrade when you should actually be downgrading ...

expect_msg = "Your database has version '%d' but this code expects version '%d'" % (db_schema.version, migrate_repository.versions.latest)
instructions = ""
if db_schema.version > migrate_repository.versions.latest:
instructions = "To downgrade the database schema you have to return to the newest Galaxy version. "

This comment has been minimized.

@nsoranzo

nsoranzo Jan 11, 2018

Member

s/return to the newest/checkout again the newer/ maybe?

@dannon

This comment has been minimized.

Member

dannon commented Jan 11, 2018

Definitely makes more sense than the upgrade message repeated :)

@dannon dannon merged commit a2f8ff2 into galaxyproject:dev Jan 11, 2018

6 checks passed

api test Build finished. 343 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 167 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 67 tests run, 0 skipped, 0 failed.
Details
selenium test Build finished. 118 tests run, 1 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details

@mvdbeek mvdbeek deleted the mvdbeek:improve_downgrade_message branch Jun 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment