Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove history+contents serializer _get_history_data #530

Merged

Conversation

Projects
None yet
2 participants
@carlfeberhard
Copy link
Contributor

commented Jul 30, 2015

Replace with serialize_contents in the five web methods that used it to bootstrap history and history contents data:

  • root.history
  • history.display_by_username_and_slug (published histories)
  • history.view (from 'Saved histories'/url in error report)
  • history.structure (the newer version: /history/structure)
  • page._get_embedded_history_html
@jmchilton

This comment has been minimized.

Copy link
Member

commented Aug 4, 2015

These components seem fine to me - really like the refactoring of names toward more generic history contents.

jmchilton added a commit that referenced this pull request Aug 4, 2015

Merge pull request #530 from carlfeberhard/managers.remove-history-data
Remove history+contents serializer _get_history_data

@jmchilton jmchilton merged commit 253ce7b into galaxyproject:dev Aug 4, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@carlfeberhard carlfeberhard deleted the carlfeberhard:managers.remove-history-data branch Aug 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.