New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.09] Fix tool report submission with sentry #5303

Merged
merged 1 commit into from Jan 12, 2018

Conversation

Projects
None yet
3 participants
@mvdbeek
Member

mvdbeek commented Jan 12, 2018

Otherwise tool error report submissions fail with:

AttributeError: 'thread._local' object has no attribute 'mapper'
  File "galaxy/tools/error_reports/__init__.py", line 58, in submit_report
    response = plugin.submit_report(dataset, job, tool, **kwargs)
  File "galaxy/tools/error_reports/plugins/sentry.py", line 80, in submit_report
    qualified=True
  File "routes/util.py", line 201, in url_for
    encoding = config.mapper.encoding
  File "routes/__init__.py", line 15, in __getattr__
    return getattr(self.__shared_state, name)

@mvdbeek mvdbeek added this to the 18.01 milestone Jan 12, 2018

@dannon

This comment has been minimized.

Member

dannon commented Jan 12, 2018

Seems safe to just drop that when it's not available. +1

@jmchilton jmchilton merged commit a6e9504 into galaxyproject:release_17.09 Jan 12, 2018

6 checks passed

api test Build finished. 295 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 162 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 46 tests run, 0 skipped, 0 failed.
Details
selenium test Build finished. No test results found.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details

@mvdbeek mvdbeek deleted the mvdbeek:sentry_hotfix branch Jun 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment