New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix common_startup.sh bashisms #5304

Merged
merged 1 commit into from Jan 12, 2018

Conversation

Projects
None yet
3 participants
@nsoranzo
Member

nsoranzo commented Jan 12, 2018

Introduced in commit 45a25a1 .

This was causing this error on the dev branch on Ubuntu (which uses dash):

$ ./run.sh
./scripts/common_startup.sh: 69: [: dev: unexpected operator
Activating virtualenv at .venv
...

instead of exiting with the "The Galaxy client build is out of date." message.

Fix common_startup.sh bashisms
Introduced in commit 45a25a1 .

This was causing this error on the `dev` branch on Ubuntu (which uses
`dash`):

```
$ ./run.sh
./scripts/common_startup.sh: 69: [: dev: unexpected operator
Activating virtualenv at .venv
...
```

instead of exiting with the "The Galaxy client build is out of date." message.
@dannon

This comment has been minimized.

Member

dannon commented Jan 12, 2018

@nsoranzo Thanks!

@dannon dannon merged commit 199457f into galaxyproject:dev Jan 12, 2018

0 of 6 checks passed

api test Test started.
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
framework test Test started.
Details
integration test Test started.
Details
selenium test Test started.
Details
toolshed test Test started.
Details

@nsoranzo nsoranzo deleted the nsoranzo:fix_common_startup.sh branch Jan 12, 2018

@afgane

This comment has been minimized.

Contributor

afgane commented Jan 13, 2018

After applying this change, I'm not able to start Galaxy using run.sh and instead get:

$ sh run.sh
Activating virtualenv at .venv
Requirement already satisfied: pip>=8.1 in ./.venv/lib/python2.7/site-packages
Could not open requirements file: [Errno 2] No such file or directory: ' requirements.txt'
@nsoranzo

This comment has been minimized.

Member

nsoranzo commented Jan 13, 2018

@afgane you're right, I shouldn't have quoted $requirement_args at line 177.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment