Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.09] Prevent reloading when data table is being modified #5331

Merged
merged 3 commits into from Jan 18, 2018

Conversation

Projects
None yet
5 participants
@mvdbeek
Copy link
Member

mvdbeek commented Jan 18, 2018

Fixes #4783.

mvdbeek added some commits Jan 18, 2018

Trigger reload for each modified data table
In unindeted one level too much in the previous commit, which would only reload
the last table (thanks @dannon). The alternative would be to reload all tables,
but I think this is more efficient.
@dannon

This comment has been minimized.

Copy link
Member

dannon commented Jan 18, 2018

Looks good to me now!

@dannon dannon merged commit 3c85407 into galaxyproject:release_17.09 Jan 18, 2018

6 checks passed

api test Build finished. 295 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 162 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 46 tests run, 0 skipped, 0 failed.
Details
selenium test Build finished. No test results found.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@martenson

This comment has been minimized.

Copy link
Member

martenson commented Jan 18, 2018

@mvdbeek nice fix! :D

@galaxybot

This comment has been minimized.

Copy link

galaxybot commented Jan 18, 2018

This PR was merged without a milestone attached.

@martenson martenson added this to the 18.01 milestone Jan 18, 2018

@mvdbeek mvdbeek deleted the mvdbeek:data_manager_reload_fix branch Jun 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.