Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the client build for selenium to in-repo script #5333

Merged
merged 2 commits into from Jan 18, 2018

Conversation

Projects
None yet
5 participants
@dannon
Copy link
Member

dannon commented Jan 18, 2018

It's currently in in the external jenkins job configuration, and I'll remove it form there if this seems to work the same. This should fix what we were seeing @nsoranzo

(this build will show a double client build, in the selenium tests output, since I haven't disabled the external invocation of this yet)

Move the client build for selenium to run_tests.sh instead of in the …
…external jenkins job configuration. Has the added benefit of skipping the client build when we don't want to run it.
@@ -16,6 +16,8 @@ fi
mkdir -p "$GALAXY_TEST_ERRORS_DIRECTORY"
mkdir -p "$GALAXY_TEST_SCREENSHOTS_DIRECTORY"

docker run -v `pwd`:`pwd`:rw -w `pwd` -u $UID node /bin/bash -c 'make client-production'

This comment has been minimized.

Copy link
@martenson

martenson Jan 18, 2018

Member

The jenkins job has make client-production-maps - I am not sure that it makes a difference here.

This comment has been minimized.

Copy link
@dannon

dannon Jan 18, 2018

Author Member

Yeah, I swapped that thinking we might as well save the little bit of time. If the selenium test output actually resolves through the sourcemaps, and it's useful, I can definitely swap it back.

This comment has been minimized.

Copy link
@jmchilton

jmchilton Jan 18, 2018

Member

I believe the sourcemaps do produce better outputs in the tests - such as for the captured console logs.

This comment has been minimized.

Copy link
@dannon

dannon Jan 18, 2018

Author Member

Hrmm, I didn't think they actually resolved through the test output, but I can swap it. Really, for the best test output, we should just do 'make client', but then it's not testing the production optimizations.

This comment has been minimized.

Copy link
@jmchilton

jmchilton Jan 18, 2018

Member

It is possible they weren't - I didn't have evidence just intuition and vague recollections.

@galaxybot galaxybot added this to the 18.01 milestone Jan 18, 2018

@nsoranzo

This comment has been minimized.

Copy link
Member

nsoranzo commented Jan 18, 2018

Thanks @dannon !

Build sourcemaps for the jenkins selenium tests -- I don't know that …
…this actually gets resolved, but it doesn't have a huge impact on build time anyway
@dannon

This comment has been minimized.

Copy link
Member Author

dannon commented Jan 18, 2018

It looks like the relocated build works well. When this is merged, we should remove the one from jenkins (and if whoever merges this doesn't have access, that's fine, I'll get it).

@martenson martenson merged commit b174daf into galaxyproject:dev Jan 18, 2018

6 checks passed

api test Build finished. 343 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 168 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 67 tests run, 0 skipped, 0 failed.
Details
selenium test Build finished. 118 tests run, 3 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
@martenson

This comment has been minimized.

Copy link
Member

martenson commented Jan 18, 2018

jenkins job's config adjusted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.