New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bam conversion test tool #5351

Merged
merged 1 commit into from Jan 19, 2018

Conversation

Projects
None yet
4 participants
@mvdbeek
Member

mvdbeek commented Jan 19, 2018

Starting with 16344a6 we attempt to set metadata also for files that have no
content. BAM files need to contain at least a header. To avoid failing tests we
only create the appropriate output based on the input.

Fix bam conversion test tool
Starting with 16344a6 we attempt to set metadata also for files that have no
content. BAM files need to contain at least a header. To avoid failing tests we
only create the appropriate output based on the input.

@galaxybot galaxybot added this to the 18.01 milestone Jan 19, 2018

@dannon

This comment has been minimized.

Member

dannon commented Jan 19, 2018

Looks like the only failure is a known flaky test we need to fix. LGTM, this should fix the test failures I'm seeing in other PRs.

@dannon dannon merged commit 718eb6c into galaxyproject:dev Jan 19, 2018

5 of 6 checks passed

api test Build finished. 343 tests run, 4 skipped, 1 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 171 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 79 tests run, 4 skipped, 0 failed.
Details
selenium test Build finished. 118 tests run, 3 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details

@mvdbeek mvdbeek deleted the mvdbeek:sam_to_bam_native_fix branch Jun 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment