New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.09] remove charlimit for fetching urls #5353

Merged
merged 1 commit into from Jan 19, 2018

Conversation

Projects
None yet
3 participants
@martenson
Member

martenson commented Jan 19, 2018

fixes #5349
this would only allow a number of urls that fit 1024 chars together
moreover it would (unless you are in luck) truncate (and break) the last one

[jxtx] So much of Galaxy was built in a world where two datasets was a lot.

remove charlimit for fetching urls
fixes #5349
this would only allow a number of urls that fit 1024 chars together
moreover it would truncate (and break) the last one

@dannon dannon merged commit 3bf9b3a into galaxyproject:release_17.09 Jan 19, 2018

4 of 6 checks passed

api test Test started.
Details
framework test Test started.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
integration test Build finished. 46 tests run, 0 skipped, 0 failed.
Details
selenium test Build finished. No test results found.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@galaxybot

This comment has been minimized.

galaxybot commented Jan 19, 2018

This PR was merged without a milestone attached.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment