New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logic in deactivate or uninstall #5363

Merged
merged 1 commit into from Jan 23, 2018

Conversation

Projects
None yet
3 participants
@davebx
Contributor

davebx commented Jan 23, 2018

The form value interpreter no longer uses ['true', 'true'] to determine whether a checkbox is checked, so a single form value of 'true' will now be sufficient.

Fix logic in deactivate or uninstall
The form value interpreter no longer uses `['true', 'true']` to determine whether a checkbox is checked, so a single form value of 'true' will now be sufficient.

@galaxybot galaxybot added the triage label Jan 23, 2018

@galaxybot galaxybot added this to the 18.01 milestone Jan 23, 2018

@martenson martenson merged commit a4154a1 into dev Jan 23, 2018

7 checks passed

api test Build finished. 343 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
framework test Build finished. 171 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 79 tests run, 4 skipped, 0 failed.
Details
selenium test Build finished. 118 tests run, 3 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details

@nsoranzo nsoranzo deleted the uninstall_repo_fix branch Jan 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment