New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History multipanel fixes #5364

Merged
merged 3 commits into from Jan 25, 2018

Conversation

Projects
None yet
2 participants
@dannon
Member

dannon commented Jan 23, 2018

This fixes #5061

Also includes a good bit of refactoring, cleanup, updates.

dannon added some commits Jan 23, 2018

Fix for history multipanel view for when the 'current' history is
deleted and/or purged.  Several bits of refactoring, import cleanup, and
a start towards documenting globals in client files touched.

@dannon dannon added this to the 18.01 milestone Jan 23, 2018

@martenson

This comment has been minimized.

Member

martenson commented Jan 24, 2018

@dannon could you please point me at which part is the fix. I read the diff twice but I must have overlooked it.

@dannon

This comment has been minimized.

Member

dannon commented Jan 25, 2018

@martenson The filter default value handling was incorrect.

@martenson martenson merged commit 5defdc7 into galaxyproject:dev Jan 25, 2018

6 checks passed

api test Build finished. 343 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 171 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 79 tests run, 4 skipped, 0 failed.
Details
selenium test Build finished. 118 tests run, 2 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment