New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove additional checkbox workarounds. #5367

Merged
merged 1 commit into from Jan 25, 2018

Conversation

Projects
None yet
3 participants
@davebx
Contributor

davebx commented Jan 23, 2018

As with #5363, the form value interpreter no longer uses ['true', 'true'] to determine whether a checkbox is checked, so a single form value of 'true' is sufficient.

@galaxybot galaxybot added the triage label Jan 23, 2018

@galaxybot galaxybot added this to the 18.01 milestone Jan 23, 2018

@@ -172,7 +172,7 @@ else:
owner = containing_repository.owner
%>
<li>
Version <b>${version | h}</b> of ${type | h} <b>${name | h}</b> contained in revision
Version <b>${version | h}</b> of ${type | h} <b>${name | h}</b> contained in revision

This comment has been minimized.

@martenson

martenson Jan 24, 2018

Member

this change might actually concatenate the strings - the space seems to be 'formatting' :/

This comment has been minimized.

@davebx

davebx Jan 25, 2018

Contributor

I just checked, it does not concatenate.

@martenson martenson merged commit 446f643 into galaxyproject:dev Jan 25, 2018

6 checks passed

api test Build finished. 343 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 171 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 79 tests run, 4 skipped, 0 failed.
Details
selenium test Build finished. 118 tests run, 3 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment