New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.09] Subworkflow creation fix #5398

Merged
merged 2 commits into from Jan 26, 2018

Conversation

Projects
None yet
3 participants
@mvdbeek
Member

mvdbeek commented Jan 26, 2018

This fixes #5396. The problem was that we would override the content_id with an
undefined value. Broken in #5249.

mvdbeek added some commits Jan 26, 2018

Fix subworkflow creation
This fixes #5396. The problem was that we would override the content_id with an
undefined value. Broken in #5249.

@mvdbeek mvdbeek added status/review and removed status/WIP labels Jan 26, 2018

@dannon dannon merged commit d6fb370 into galaxyproject:release_17.09 Jan 26, 2018

5 of 6 checks passed

api test Build finished. 295 tests run, 4 skipped, 1 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 295 tests run, 4 skipped, 0 failed.
Details
integration test Build finished. 46 tests run, 0 skipped, 0 failed.
Details
selenium test Build finished. No test results found.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@dannon

This comment has been minimized.

Member

dannon commented Jan 26, 2018

Thanks @mvdbeek, good catch.

@martenson martenson added this to the 18.01 milestone Jan 26, 2018

@dannon dannon modified the milestone: 18.01 Jan 26, 2018

@galaxyproject galaxyproject deleted a comment from galaxybot Jan 26, 2018

@mvdbeek mvdbeek deleted the mvdbeek:subworkflow_creation_fix branch Jun 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment