New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.01] Fix server_name when config is a dict #5447

Merged
merged 2 commits into from Feb 5, 2018

Conversation

Projects
None yet
2 participants
@natefoo
Member

natefoo commented Feb 2, 2018

Scripts do this, so you can't assume the config is an actual Configuration object. Fixes #5420.

Also, an (unintended)? consequence of my server name hacking is that you can only set the server name by setting server_name in the config file (any), galaxy-main --server-name (webless), or [server:name] (paste). The default base server name is main, I think maybe @jmchilton had intended for it to be the webapp name (e.g. galaxy)?

@natefoo natefoo added this to the 18.01 milestone Feb 2, 2018

@natefoo

This comment has been minimized.

Member

natefoo commented Feb 2, 2018

These are good tests, we should have them for job handlers.

@natefoo natefoo changed the title from Fix server_name when config is a dict to [18.01] Fix server_name when config is a dict Feb 5, 2018

@dannon dannon merged commit 2cb3af5 into galaxyproject:release_18.01 Feb 5, 2018

5 of 6 checks passed

selenium test Build finished. 118 tests run, 3 skipped, 2 failed.
Details
api test Build finished. 344 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 171 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 79 tests run, 4 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment