New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.01] Revert #5036 #5470

Merged
merged 2 commits into from Feb 7, 2018

Conversation

Projects
None yet
2 participants
@natefoo
Member

natefoo commented Feb 7, 2018

Two issues arose on Main from this:

  1. Dependencies in conda were resolving but their setup commands were not being returned by dependency_shell_commands(). This probably happens when the dependencies are also resolvable via the versionless galaxy package resolver.
  2. All tools were resolving samtools 0.1.18 as a dependency. This is probably because I have default symlinked to 0.1.18 in <tool_dependency_dir>/samtools. But why it is resolving samtools at all is still unknown.

@natefoo natefoo added this to the 18.01 milestone Feb 7, 2018

@natefoo natefoo requested a review from mvdbeek Feb 7, 2018

@dannon dannon merged commit 62540a9 into galaxyproject:release_18.01 Feb 7, 2018

6 checks passed

api test Build finished. 351 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 171 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 79 tests run, 4 skipped, 0 failed.
Details
selenium test Build finished. 118 tests run, 3 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details

@natefoo natefoo referenced this pull request Feb 12, 2018

Closed

DESeq2 Fatal Error #1708

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment