New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.01] Fix common_startup.sh for galaxy tarballs #5491

Merged
merged 3 commits into from Feb 8, 2018

Conversation

Projects
None yet
3 participants
@nsoranzo
Member

nsoranzo commented Feb 8, 2018

Do not assume git is installed and the .git directory is present.

Fix #5466.

Includes also a backport of #5375.

natefoo and others added some commits Jan 24, 2018

esac
else
GIT_BRANCH=0
DEV_WHEELS=1

This comment has been minimized.

@natefoo

natefoo Feb 8, 2018

Member

Dev wheels will be installed even if we don't need to build the client, is this desirable?

This comment has been minimized.

@nsoranzo

nsoranzo Feb 8, 2018

Member

Since we don't know which branch the tarball comes from, we have to always build the client the first time.

This comment has been minimized.

@natefoo

natefoo Feb 8, 2018

Member

We should consider committing the client_build_hash.txt in release branches, but this is a good solution for now.

@natefoo

natefoo approved these changes Feb 8, 2018

@dannon dannon merged commit d910780 into galaxyproject:release_18.01 Feb 8, 2018

6 checks passed

api test Build finished. 351 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 171 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 79 tests run, 4 skipped, 0 failed.
Details
selenium test Build finished. 118 tests run, 2 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details

@nsoranzo nsoranzo deleted the nsoranzo:release_18.01_fix_common_startup_for_bare_clone branch Feb 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment