New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.01] Optimize database interaction for user workflow list. #5515

Merged
merged 1 commit into from Feb 13, 2018

Conversation

Projects
None yet
3 participants
@jmchilton
Member

jmchilton commented Feb 13, 2018

Don't LEFT OUTER JOIN workflow against its steps to produce step count - this causes a lot of duplicated workflow data and fetches step data not needed to just produce a step count.

Tweak pre-fetching for workflows shared with user also.

Optimize database interaction for user workflow list.
Don't LEFT OUTER JOIN workflow against its steps to produce step count - this causes a lot of duplicated workflow data and fetches step data not needed to just produce a step count.

Tweak pre-fetching for workflows shared with user also.
@mvdbeek

This comment has been minimized.

Member

mvdbeek commented Feb 13, 2018

That is much nicer!

@martenson

This comment has been minimized.

Member

martenson commented Feb 13, 2018

xref #5473

@martenson martenson merged commit fd1ac05 into galaxyproject:release_18.01 Feb 13, 2018

6 checks passed

api test Build finished. 351 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 171 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 79 tests run, 4 skipped, 0 failed.
Details
selenium test Build finished. 118 tests run, 3 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment