New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for GenomeSpace importer/exporter #5528

Merged
merged 1 commit into from Feb 15, 2018

Conversation

Projects
None yet
4 participants
@nuwang
Member

nuwang commented Feb 14, 2018

Closes: #5527

This needs to be patched into the 18.01 branch, as it's currently broken on Galaxy main.

@galaxybot galaxybot added the triage label Feb 14, 2018

@galaxybot galaxybot added this to the 18.05 milestone Feb 14, 2018

@mvdbeek mvdbeek changed the base branch from dev to release_18.01 Feb 14, 2018

@mvdbeek mvdbeek changed the base branch from release_18.01 to dev Feb 14, 2018

@mvdbeek mvdbeek added kind/bug area/tools and removed triage labels Feb 14, 2018

@mvdbeek mvdbeek changed the title from Fix for: https://github.com/galaxyproject/galaxy/issues/5527 to [18.01] Fix for: https://github.com/galaxyproject/galaxy/issues/5527 Feb 14, 2018

@nuwang nuwang closed this Feb 14, 2018

@nuwang nuwang reopened this Feb 14, 2018

@martenson martenson changed the title from [18.01] Fix for: https://github.com/galaxyproject/galaxy/issues/5527 to [18.01] Fix for GenomeSpace importer/exporter Feb 15, 2018

@martenson

This comment has been minimized.

Member

martenson commented Feb 15, 2018

@nuwang this is targeting the wrong branch if the title is correct

edit: the source branch is not clean 18.01 so we will need to backport this after merge, I will update the title to reflect that

@martenson martenson changed the base branch from dev to release_18.01 Feb 15, 2018

@martenson martenson changed the base branch from release_18.01 to dev Feb 15, 2018

@martenson martenson changed the title from [18.01] Fix for GenomeSpace importer/exporter to Fix for GenomeSpace importer/exporter Feb 15, 2018

@martenson martenson modified the milestones: 18.05, 18.01 Feb 15, 2018

@nuwang

This comment has been minimized.

Member

nuwang commented Feb 15, 2018

@martenson It's currently broken on both Galaxy main (18.01) and the dev branch.

@martenson

This comment has been minimized.

Member

martenson commented Feb 15, 2018

@nuwang Understood, I will make sure it is fixed in 18.01. Thank you!

@martenson martenson merged commit 298ef7e into galaxyproject:dev Feb 15, 2018

6 checks passed

api test Build finished. 351 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 173 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 79 tests run, 4 skipped, 0 failed.
Details
selenium test Build finished. 118 tests run, 1 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
@martenson

This comment has been minimized.

Member

martenson commented Feb 15, 2018

backported here: 8c941ae

@nuwang

This comment has been minimized.

Member

nuwang commented Feb 15, 2018

@martenson Great, thanks for patching it in!

@martenson

This comment has been minimized.

Member

martenson commented Feb 15, 2018

@nuwang should get to Main later today

@nuwang

This comment has been minimized.

Member

nuwang commented Feb 15, 2018

@martenson I forgot to ask - this needs a client rebuild - does that happen automatically now?

@martenson

This comment has been minimized.

Member

martenson commented Feb 15, 2018

@nuwang yep, you need not to worry about that anymore

@martenson

This comment has been minimized.

Member

martenson commented Feb 16, 2018

@nuwang deployed

@nuwang

This comment has been minimized.

Member

nuwang commented Feb 16, 2018

@martenson Works now, thanks!

@martenson

This comment has been minimized.

Member

martenson commented Feb 16, 2018

thank you for fixing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment