Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search overlay JS errors #5531

Merged
merged 1 commit into from Feb 15, 2018

Conversation

Projects
None yet
4 participants
@anuprulez
Copy link
Member

anuprulez commented Feb 14, 2018

This PR fixes the bug #5522
ping @martenson

@galaxybot galaxybot added the triage label Feb 14, 2018

@galaxybot galaxybot added this to the 18.05 milestone Feb 14, 2018

@dannon dannon changed the title Fix the bug Fix search overlay JS errors Feb 14, 2018

@nsoranzo

This comment has been minimized.

Copy link
Member

nsoranzo commented Feb 14, 2018

Is the bug present on 18.01 too?

@anuprulez

This comment has been minimized.

Copy link
Member Author

anuprulez commented Feb 14, 2018

I think yes because the lines which I updated to fix the bug are present in 18.01.

@anuprulez

This comment has been minimized.

Copy link
Member Author

anuprulez commented Feb 14, 2018

I think the build failed for the same reasons as were for #5507

@martenson martenson modified the milestones: 18.05, 18.01 Feb 15, 2018

@martenson

This comment has been minimized.

Copy link
Member

martenson commented Feb 15, 2018

Thank you @anuprulez !

@martenson martenson merged commit 92826fe into galaxyproject:dev Feb 15, 2018

6 checks passed

api test Build finished. 351 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 173 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 79 tests run, 4 skipped, 0 failed.
Details
selenium test Build finished. 118 tests run, 1 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
@martenson

This comment has been minimized.

Copy link
Member

martenson commented Feb 15, 2018

backported to 18.01 in a269a95

@anuprulez anuprulez deleted the bgruening:bugfix_#5522 branch Feb 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.