Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.01] Improve performance bugs and misleading summary info in history list. #5533

Merged
merged 2 commits into from Feb 15, 2018

Conversation

Projects
None yet
2 participants
@jmchilton
Copy link
Member

commented Feb 14, 2018

Prefetch shared user information as counts instead of objects and do so in initial query to eliminate an extra 15 SQL queries per page and load less data related to sharing.

Replace columns that would cause HDA information to be joined into the query (history size and HDA state counts) with a spinner that will be fetched in subsequent queries on the client end. There can hundreds of thousands of datasets per history - this information shouldn't be summarized to get the initial page to render - it can be fetched one history at a time once the page is rendered.

This commit also adds a new column "Items" that corresponds to the next HID - and that I think is a good summary of the "history size" before the dataset state information is loaded and even gives additional information because that count includes collections. This also renders state information for deleted and hidden datasets that was previously missing and could cause confusion. That said I don't like the dataset summaries - I'd rather just have the item count and then job state summaries (and maybe workflow state summaries as well).

Safer alternative to #5504 - that PR also pre-fetched the tags in the initial join - which very likely would have been a good idea but under some circumstances might not be (if there are on average many tags per query). That PR also prefetched the users shared with instead of just the counts - fetching just the counts should pretty much always be the better choice.

Improve performance bugs and misleading summary info in history list.
Prefetch shared user information as counts instead of objects and do so in initial query to eliminate an extra 15 SQL queries per page and load less data related to sharing.

Replace columns that would cause HDA information to be joined into the query (history size and HDA state counts) with a spinner that will be fetched in subsequent queries on the client end. There can hundreds of thousands of datasets per history - this information shouldn't be summarized to get the initial page to render - it can be fetched one history at a time once the page is rendered.

This commit also adds a new column "Items" that corresponds to the next HID - and that I think is a good summary of the "history size" before the dataset state information is loaded and even gives additional information because that count includes collections. This also renders state information for deleted and hidden datasets that was previously missing and could cause confusion. That said I don't like the dataset summaries - I'd rather just have the item count and then job state summaries.
style changes for history lists
* include title for all state indicators
* shorten title
* change style of deleted indicator
* comment out unused less variables
@martenson

This comment has been minimized.

Copy link
Member

commented Feb 15, 2018

styling changes:
screenshot 2018-02-15 10 37 30

@jmchilton

This comment has been minimized.

Copy link
Member Author

commented Feb 15, 2018

Much nicer than what I had - thanks a bunch @martenson !

@martenson martenson merged commit 42c12c5 into galaxyproject:release_18.01 Feb 15, 2018

4 of 6 checks passed

api test Build finished. 351 tests run, 5 skipped, 1 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
framework test Build finished. 171 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 79 tests run, 4 skipped, 0 failed.
Details
selenium test Build finished. 118 tests run, 3 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details

@martenson martenson added this to the 18.01 milestone Feb 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.