New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.01] optimize nonadmin and nonanon library list permission queries #5542

Merged
merged 1 commit into from Feb 15, 2018

Conversation

Projects
None yet
2 participants
@martenson
Member

martenson commented Feb 14, 2018

Before, the code would emit extra queries per each library to
find out whether the current user has permissions on it.
By pre-fetching all of them in one query and passing around as
a dict object we should see a considerable speedup on Galaxies
with many libraries.

thanks to @jmchilton for help with the query

@martenson

This comment has been minimized.

Member

martenson commented Feb 14, 2018

xref #5474

@martenson martenson added this to the 18.01 milestone Feb 14, 2018

optimize nonadmin and nonanon library list permission queries
Before, the code would emit extra queries per each library to
find out whether the current user has permissions on it.
By pre-fetching all of them in one query and passing around as
 a dict object we should see a considerable speedup on Galaxies
with many libraries.

@jmchilton jmchilton merged commit 296af58 into galaxyproject:release_18.01 Feb 15, 2018

6 checks passed

api test Build finished. 351 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 171 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 79 tests run, 4 skipped, 0 failed.
Details
selenium test Build finished. 118 tests run, 2 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details

@martenson martenson deleted the martenson:optimize-nonadmin-nonanon-datalibs branch Feb 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment