New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.01] Do not remove external path files during library uploads #5573

Merged
merged 3 commits into from Feb 22, 2018

Conversation

Projects
None yet
2 participants
@nsoranzo
Member

nsoranzo commented Feb 21, 2018

xref. #5264 (comment)

Also updated integration test to prevent regressions.

@nsoranzo nsoranzo added status/review and removed status/WIP labels Feb 21, 2018

@jmchilton

This comment has been minimized.

Member

jmchilton commented Feb 22, 2018

Thanks for working through this and adding the test - this makes sense to me!

@jmchilton jmchilton merged commit d937273 into galaxyproject:release_18.01 Feb 22, 2018

6 checks passed

api test Build finished. 351 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 171 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 79 tests run, 4 skipped, 0 failed.
Details
selenium test Build finished. 118 tests run, 5 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details

@nsoranzo nsoranzo deleted the nsoranzo:release_18.01_fix_filesystem_library_uploads branch Feb 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment