New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.01] Paginate published workflows grid. #5576

Merged
merged 1 commit into from Feb 22, 2018

Conversation

Projects
None yet
2 participants
@jmchilton
Member

jmchilton commented Feb 21, 2018

@martenson mentioned he prefers the look and feel of the published history grid so this replicates that and very likely will result in quicker rendering on usegalaxy.org - though we should verify this after it is deployed since the paginated grid do result in two big join queries instead of one big query - but I suspect rendering details on fewer objects (which includes fetching tag information from the db) will saved more than enough to make up for that.

Labelling this as a performance bug in order to target 18.01 - but I can target usegalaxy branch if people would be more comfortable with that.

Paginate published workflow grid.
@martenson mentioned he prefers the look and feel of the published history grid so this replicates that and very likely will result in quicker rendering on usegalaxy.org - though we should verify this after it is deployed since the paginated grid do result in two big join queries instead of one big query - but I suspect rendering details on fewer objects (which includes fetching tag information from the db) will saved more than enough to make up for that.
@martenson

This comment has been minimized.

Member

martenson commented Feb 21, 2018

@galaxybot test this

@jmchilton jmchilton referenced this pull request Feb 22, 2018

Closed

Slow grid / list view problems #5473

0 of 4 tasks complete

@martenson martenson merged commit 8cc675e into galaxyproject:release_18.01 Feb 22, 2018

6 checks passed

api test Build finished. 351 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 171 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 79 tests run, 4 skipped, 0 failed.
Details
selenium test Build finished. 118 tests run, 3 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details

@martenson martenson added this to the 18.01 milestone Feb 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment