New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.01] Fix small bam (header-only) infinite fetching #5579

Merged
merged 3 commits into from Feb 21, 2018

Conversation

Projects
None yet
6 participants
@dannon
Member

dannon commented Feb 21, 2018

fixes #5577

@mvdbeek

Thanks @dannon and @blankenberg!

@blankenberg

This comment has been minimized.

Member

blankenberg commented Feb 21, 2018

+1

Thanks!

except Exception as e:
offset = -1
ck_data = "Could not display BAM file, error was:\n%s" % e.message
ck_data = "Could not display BAM file, error was:\n%s" % str(e)

This comment has been minimized.

@nsoranzo

nsoranzo Feb 21, 2018

Member

The str() casting shouldn't be necessary, I think, but we have tons of these anyway.

@jmchilton jmchilton merged commit 8afeffe into galaxyproject:release_18.01 Feb 21, 2018

4 of 6 checks passed

api test Build finished. 351 tests run, 4 skipped, 1 failed.
Details
selenium test Test started.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 171 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 79 tests run, 4 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details

@martenson martenson added this to the 18.01 milestone Feb 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment