New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.01] Backport toolbox cache #5583

Merged
merged 2 commits into from Feb 27, 2018

Conversation

Projects
None yet
3 participants
@martenson
Member

martenson commented Feb 21, 2018

backport of #5570 and #5600

implement basic cache on toolbox to_dict objects
base the cache on absence of filters

allow cache for users that don't opt in for filters
@nsoranzo

This comment has been minimized.

Member

nsoranzo commented Feb 26, 2018

@martenson You may want to add the commit from #5600 to this PR.

move the cache from toolbox level to tool level
the cache remains toolbox-specific so
it is stored within the toolbox object

includes refactor thanks to eagle eyes
@martenson

This comment has been minimized.

Member

martenson commented Feb 26, 2018

I have added that commit but leaving this in WIP until I have relevant data from Test.

@martenson

This comment has been minimized.

Member

martenson commented Feb 26, 2018

The caching on tool level seems to be slightly worse than the previous toolbox level but still a significant speedup. Taking out of WIP.

@martenson martenson added status/review and removed status/WIP labels Feb 26, 2018

@jmchilton jmchilton merged commit a90c3a1 into galaxyproject:release_18.01 Feb 27, 2018

6 checks passed

api test Build finished. 351 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 171 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 79 tests run, 4 skipped, 0 failed.
Details
selenium test Build finished. 118 tests run, 1 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment