New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.09] Changed GenomeSpace token handling to use manual OpenID association only #5631

Merged
merged 3 commits into from Mar 6, 2018

Conversation

Projects
None yet
5 participants
@martenson
Member

martenson commented Mar 1, 2018

I cherry picked @nuwang's work to 17.09, resolved few conflicts, please review.

@martenson martenson requested review from blankenberg, nuwang and nsoranzo Mar 1, 2018

@galaxybot galaxybot added the triage label Mar 1, 2018

@nsoranzo

This comment has been minimized.

Member

nsoranzo commented Mar 1, 2018

@martenson Missing a make client? This is 17.09.

@martenson

This comment has been minimized.

Member

martenson commented Mar 1, 2018

Yeah it is missing client, I will add when it is ok'd, is that ok?

@nsoranzo

This comment has been minimized.

Member

nsoranzo commented Mar 1, 2018

Tool changes looks good, can't say about changes in client/

@nuwang

This comment has been minimized.

Member

nuwang commented Mar 2, 2018

@martenson Thanks for backporting this. Other than the make client as @nsoranzo suggested, it looks ok to me too.

@martenson martenson added this to the 18.01 milestone Mar 2, 2018

martenson added some commits Mar 2, 2018

@martenson

This comment has been minimized.

Member

martenson commented Mar 2, 2018

client is built now

@mvdbeek mvdbeek merged commit f8d44c2 into galaxyproject:release_17.09 Mar 6, 2018

6 checks passed

api test Build finished. 295 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 162 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 46 tests run, 0 skipped, 0 failed.
Details
selenium test Build finished. No test results found.
Details
toolshed test Build finished. 579 tests run, 0 skipped, 0 failed.
Details
@nsoranzo

This comment has been minimized.

Member

nsoranzo commented Mar 6, 2018

@martenson Can you merge this forward, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment