New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.01] Consistent sniffing regardless of in_place. #5643

Merged
merged 1 commit into from Mar 9, 2018

Conversation

Projects
None yet
2 participants
@jmchilton
Member

jmchilton commented Mar 6, 2018

Previously sniffing would happen on the original file (before carriage returns and tabular spaces were converted) if in_place was false and on the converted file if it was true. This fixes it to always sniff the converted file - which I think is the right call (at least in the case of Mac OS CSV files that I am chasing down as part of #5220).

Consistent sniffing regardless of in_place.
Previously sniffing would happen on the original file (before carriage returns and tabular spaces were converted) if in_place was false and on the converted file if it was true.

@nsoranzo nsoranzo merged commit e72e02c into galaxyproject:release_18.01 Mar 9, 2018

6 checks passed

api test Build finished. 351 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 173 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 79 tests run, 4 skipped, 0 failed.
Details
selenium test Build finished. 118 tests run, 2 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details

@nsoranzo nsoranzo added this to the 18.01 milestone Mar 9, 2018

@galaxyproject galaxyproject deleted a comment from galaxybot Mar 9, 2018

nsoranzo added a commit to martenson/galaxy that referenced this pull request Mar 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment