New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.01] Do not sniff BamInputSorted #5644

Merged
merged 1 commit into from Mar 7, 2018

Conversation

Projects
None yet
4 participants
@mvdbeek
Member

mvdbeek commented Mar 6, 2018

Only aligners should produce this datatype. If an alignment
is not explicitly coordinate or queryname sorted it should
be BamNative.
Also addresses #5628 (comment),
though I think the sniff order should be dependent on the order with which
datatypes are loaded.

Do not sniff BamInputSorted
Only aligners should produce this datatype. If an alignment
is not explicitly coordinate or queryname sorted it should
be BamNative.
Also addresses #5628 (comment),
though I think the sniff order should be dependent on the order with which
datatypes are loaded.

@jmchilton jmchilton merged commit 9e6f3f5 into galaxyproject:release_18.01 Mar 7, 2018

6 checks passed

api test Build finished. 351 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 173 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 79 tests run, 4 skipped, 0 failed.
Details
selenium test Build finished. 118 tests run, 3 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
@jmchilton

This comment has been minimized.

Member

jmchilton commented Mar 7, 2018

Thanks for the fix @mvdbeek, really appreciate it.

@galaxybot

This comment has been minimized.

galaxybot commented Mar 7, 2018

This PR was merged without a milestone attached.

@martenson martenson added this to the 18.01 milestone Mar 7, 2018

@mvdbeek mvdbeek deleted the mvdbeek:disable_sniffer_qname_input_sorted branch Jun 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment