New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.01] Use sample file path when adding missing indexes #5650

Merged
merged 1 commit into from Mar 8, 2018

Conversation

Projects
None yet
2 participants
@mvdbeek
Member

mvdbeek commented Mar 7, 2018

Previously we would load a TS tool during installation and ask if any of its
tool datat tables are missing loc files. If that's the case we copy the sample
file and call handle_found_index_file for the particular missing *.loc path
of this data table.

This does not work if the data table already existed (e.g for built-in data
tables), but was missing the *.loc file, since we would attempt to load that
path. Instead we do now load the path to the loc file that we just copied.

Should fix #5648.

Use target file path when adding missing indexes
Previously we would load a TS tool during installation and ask if any of its
tool datat tables are missing loc files. If thats the case we copy the sample
file and call `handle_found_index_file` for the particular missing *.loc path
of this data table.

This does not work if the data table already existed (e.g for built-in data
tables), but was missing the *.loc file, since we would atempt to load that
path. Instead we do now load the path to the loc file that we just copied.

Should fix #5648.

@mvdbeek mvdbeek changed the title from [18.01] [WIP] Use sample file path when adding missing indexes to [18.01] Use sample file path when adding missing indexes Mar 7, 2018

@mvdbeek mvdbeek added status/review and removed status/WIP labels Mar 7, 2018

@mvdbeek

This comment has been minimized.

Member

mvdbeek commented Mar 7, 2018

Tested this with @bgruening's image and it resolves #5648

@bgruening

This comment has been minimized.

Member

bgruening commented Mar 8, 2018

Cool thanks Marius.

@bgruening bgruening merged commit 206182e into galaxyproject:release_18.01 Mar 8, 2018

6 checks passed

api test Build finished. 351 tests run, 4 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 173 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 79 tests run, 4 skipped, 0 failed.
Details
selenium test Build finished. 118 tests run, 1 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details

@mvdbeek mvdbeek added this to the 18.01 milestone Mar 8, 2018

@galaxyproject galaxyproject deleted a comment from galaxybot Mar 8, 2018

@mvdbeek mvdbeek deleted the mvdbeek:missing_index_file_fixes branch Jun 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment