Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Citation style work #6427

Merged
merged 1 commit into from Jul 1, 2018
Merged

Citation style work #6427

merged 1 commit into from Jul 1, 2018

Conversation

@dannon
Copy link
Member

dannon commented Jun 30, 2018

Got busted somehow in recent work (in dev), so I took the opportunity to use bs-vue and refresh the styles and formatting a bit.

@galaxybot galaxybot added the triage label Jun 30, 2018
@galaxybot galaxybot added this to the 18.09 milestone Jun 30, 2018
@bgruening bgruening added area/UI-UX and removed triage labels Jul 1, 2018
@bgruening

This comment has been minimized.

Copy link
Member

bgruening commented Jul 1, 2018

Cool, thanks @dannon!

@martenson

This comment has been minimized.

Copy link
Member

martenson commented Jul 1, 2018

The style of this is based on #6422 which I suspect will not get merged that soon since it requires a lot of testing. Do we want to drift freely towards that with isolated components?

screenshot 2018-07-01 12 51 27

A minor thing is that now the bibtex is not rendered within editable textarea, which makes it harder to select.

@martenson martenson merged commit 01ba96a into galaxyproject:dev Jul 1, 2018
5 checks passed
5 checks passed
api test Build finished. 396 tests run, 1 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 180 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 111 tests run, 5 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.