Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

declutter the history 'cog' menu #6437

Merged
merged 1 commit into from Apr 9, 2019

Conversation

Projects
None yet
5 participants
@martenson
Copy link
Member

commented Jul 1, 2018

  • move the 'import from file' to the saved histories page
@dannon

This comment has been minimized.

Copy link
Member

commented Jul 18, 2018

@martenson Looks like a reasonable first step forward -- I'm not sure how to best approach most of the other stuff. Want to just get this merged and take the rest of it in separate PRs?

@martenson martenson changed the title [WIP] declutter the history 'cog' menu declutter the history 'cog' menu Mar 19, 2019

@martenson martenson added status/review and removed status/WIP labels Mar 19, 2019

@martenson martenson added this to the 19.05 milestone Mar 19, 2019

@martenson

This comment has been minimized.

Copy link
Member Author

commented Mar 19, 2019

ready for review

header: true
},
{
html: _l("Import from File"),

This comment has been minimized.

Copy link
@nsoranzo

nsoranzo Mar 19, 2019

Member

What about putting it together with the previous section, to be renamed from Downloads to Import/Export ?

This comment has been minimized.

Copy link
@martenson

martenson Mar 19, 2019

Author Member

I still think it does not belong in the current history 'context' menu at all.

This comment has been minimized.

Copy link
@nsoranzo

nsoranzo Mar 19, 2019

Member

We have "Create New" under the "Current History" header...

This comment has been minimized.

Copy link
@martenson

martenson Mar 19, 2019

Author Member

That should imo go away too, along with other options.

This comment has been minimized.

Copy link
@nsoranzo

nsoranzo Mar 19, 2019

Member

Thanks for #7565 ! IMO import and export should be together, but it's a -0.

@martenson martenson force-pushed the martenson:declutter-history-menu branch from 82f6d08 to bab975c Mar 19, 2019

@nsoranzo nsoranzo merged commit b8285b6 into galaxyproject:dev Apr 9, 2019

7 checks passed

api test Build finished. 465 tests run, 1 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 213 tests run, 0 skipped, 0 failed.
Details
get_code_and_test Workflow: get_code_and_test
Details
integration test Build finished. 297 tests run, 19 skipped, 0 failed.
Details
selenium test Build finished. 151 tests run, 2 skipped, 0 failed.
Details
toolshed test Build finished. 578 tests run, 0 skipped, 0 failed.
Details

@nsoranzo nsoranzo deleted the martenson:declutter-history-menu branch Apr 9, 2019

@martenson

This comment has been minimized.

Copy link
Member Author

commented Apr 9, 2019

thank you @nsoranzo and @jmchilton

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.