Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate tagging into the rule builder. #6500

Merged
merged 2 commits into from Jul 18, 2018

Conversation

@jmchilton
Copy link
Member

jmchilton commented Jul 13, 2018

  • Allow specifying name tags, group tags (added in #6491), and "general" or generic tags on stand-alone datasets and collection content datasets.
  • Allow reusing the collection name as a name tag during upload for the whole collection. In this context I think the name tag is especially useful and will typically be the same name as the collection so the UI is kept simple by making it a checkbox.

Ideas tracked on #5822.

Builds on #6499.

@jmchilton jmchilton added this to the 18.09 milestone Jul 13, 2018
@jmchilton jmchilton changed the title Integrate tagging into the rule builder. [WIP] Integrate tagging into the rule builder. Jul 13, 2018
@jmchilton jmchilton force-pushed the jmchilton:rule_builder_tags branch from 8939c49 to 5b59f03 Jul 14, 2018
Rebased with default argument handling improvements suggested by Marius.
@jmchilton jmchilton force-pushed the jmchilton:rule_builder_tags branch from 5b59f03 to f9ba8d3 Jul 16, 2018
- Allow specifying name tags, group tags, and "general" tags on stand-alone datasets and collection content datasets.
- Allow reusing the collection name as a name tag during upload for the whole collection. In this context I think the name tag is especially useful and will typically be the same name as the collection so the UI is kept simple by making it a checkbox.
@jmchilton jmchilton changed the title [WIP] Integrate tagging into the rule builder. Integrate tagging into the rule builder. Jul 16, 2018
@jmchilton jmchilton added status/review and removed status/WIP labels Jul 16, 2018
@dannon

This comment has been minimized.

Copy link
Member

dannon commented Jul 18, 2018

+1

@dannon dannon merged commit 489839c into galaxyproject:dev Jul 18, 2018
5 checks passed
5 checks passed
api test Build finished. 397 tests run, 1 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 182 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 111 tests run, 5 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
@dannon dannon added this to Done in Collections via automation Jul 18, 2018
@erasche erasche mentioned this pull request Nov 29, 2018
0 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Collections
  
Done
3 participants
You can’t perform that action at this time.