Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ts api improvements #6652

Merged
merged 11 commits into from Apr 3, 2019

Conversation

@davebx
Copy link
Contributor

commented Aug 29, 2018

  • Paginate repositories in category if count exceeds set number
  • Allow sorting by name, owner, description
  • Add a numeric_revision column to the changeset metadata table

davebx added some commits Aug 29, 2018

@dannon

This comment has been minimized.

Copy link
Member

commented Sep 6, 2018

@davebx Are the toolshed test failures related, here?

@davebx

This comment has been minimized.

Copy link
Contributor Author

commented Sep 6, 2018

@dannon I doubt it, but I haven't actually verified that.

@dannon dannon modified the milestones: 18.09, 19.01 Sep 6, 2018

@nsoranzo

This comment has been minimized.

Copy link
Member

commented Sep 6, 2018

@davebx I've restarted the toolshed tests, and exactly the same 3 tests failed. I've rarely seen TS tests fail randomly lately, so I fear these are related to the PR. Maybe you can try to rebase the PR and git bisect to find which commit broke the tests?

@jmchilton

This comment has been minimized.

Copy link
Member

commented Dec 12, 2018

Marking as WIP due to the test failures. I'm kicking it for now, but happy to review and try to get it into 19.01 if the tests can be fixed sooner.

davebx added some commits Apr 1, 2019

@davebx

This comment has been minimized.

Copy link
Contributor Author

commented Apr 2, 2019

Well, at least the toolshed tests passed this time.

@martenson martenson merged commit ea303aa into galaxyproject:dev Apr 3, 2019

5 of 7 checks passed

api test Build finished. 481 tests run, 1 skipped, 1 failed.
Details
integration test Build finished. 300 tests run, 19 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 213 tests run, 0 skipped, 0 failed.
Details
get_code_and_test Workflow: get_code_and_test
Details
selenium test Build finished. 151 tests run, 3 skipped, 0 failed.
Details
toolshed test Build finished. 578 tests run, 0 skipped, 0 failed.
Details

@martenson martenson removed the status/WIP label Apr 3, 2019

@martenson martenson deleted the davebx:ts_api_improvements branch Apr 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.