Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wf-editor when loading subworkflow with parenthesis in label #6680

Merged
merged 1 commit into from Sep 7, 2018

Conversation

@mvdbeek
Copy link
Member

mvdbeek commented Sep 7, 2018

This fixes #6031

Otherwise this leads to:

```
webpack-internal:///0:1468 Uncaught Error: Syntax error, unrecognized expression: .callout.with (parenthesis)
    at Function.Sizzle.error (webpack-internal:///0:1468)
    at Sizzle.tokenize (webpack-internal:///0:2125)
    at Function.Sizzle (webpack-internal:///0:838)
    at Function.jQuery.find (webpack-internal:///453:290)
    at jQuery.fn.init.find (webpack-internal:///0:2792)
    at jQuery.fn.init.jQuery.fn.find (webpack-internal:///453:677)
    at child.eval (webpack-internal:///760:322)
    at Function.each (webpack-internal:///0:371)
    at Object.eval (webpack-internal:///760:319)
    at Function.each (webpack-internal:///0:371)
```
@jmchilton

This comment has been minimized.

Copy link
Member

jmchilton commented Sep 7, 2018

api test — Build finished. 420 tests run, 1 skipped, 0 failed.
selenium test — Build finished. 420 tests run, 1 skipped, 0 failed.

I continue to fail badly.

@jmchilton jmchilton merged commit f519491 into galaxyproject:dev Sep 7, 2018
6 checks passed
6 checks passed
api test Build finished. 420 tests run, 1 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 187 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 118 tests run, 5 skipped, 0 failed.
Details
selenium test Build finished. 420 tests run, 1 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
@galaxybot

This comment has been minimized.

Copy link

galaxybot commented Sep 8, 2018

This PR was merged without a milestone attached.

@nsoranzo nsoranzo deleted the mvdbeek:subworkflow_escape_names branch Sep 8, 2018
@nsoranzo nsoranzo added this to the 18.09 milestone Sep 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.