Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.05] Cast rule.length to int when parsing rules #6802

Merged
merged 2 commits into from Oct 1, 2018

Conversation

@mvdbeek
Copy link
Member

mvdbeek commented Sep 29, 2018

Fixes #6800

To rebuild the client I did make client-production-maps, but I didn't add the changes in static/style/blue/base.css, those changes seem unrelated ?

mvdbeek added 2 commits Sep 29, 2018
When using the little up/down button we get strings instead of integers,
and those fail the rule validation. Fixes #6800
@dannon dannon added this to the 18.09 milestone Oct 1, 2018
@dannon dannon merged commit 2aad3b2 into galaxyproject:release_18.05 Oct 1, 2018
6 checks passed
6 checks passed
api test Build finished. 397 tests run, 1 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 178 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 111 tests run, 5 skipped, 0 failed.
Details
selenium test Build finished. 139 tests run, 2 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
@dannon

This comment has been minimized.

Copy link
Member

dannon commented Oct 1, 2018

@mvdbeek build looked fine to me; merged forward. The good news is that past 18.05, we won't ever be committing those again, so it'll all just work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.