Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.09] do not rule out numbers that are accessed with shift modifier #6810

Merged
merged 1 commit into from Oct 4, 2018

Conversation

@martenson
Copy link
Member

martenson commented Oct 1, 2018

closes #5370
I think there are more problems with this code:

  • it assumes too much about the keyboard used and puts
    unnecessary restrictions on the user
  • the implementation should be refactored to use KeyboardEvent.key
    instead of the deprecated charCode

edit: the problems are listed as 'future work', I do not think they stop this PR

closes #5370
I think there are more problems with this code:
 - it assumes too much about the keyboard used and puts
unnecessary restrictions on the user
 - the implementation should be refactored to use KeyboardEvent.key
instead of the deprecated charCode
@martenson martenson added this to the 18.09 milestone Oct 1, 2018
@martenson martenson requested a review from guerler Oct 1, 2018
@mvdbeek mvdbeek merged commit 8ea4553 into galaxyproject:release_18.09 Oct 4, 2018
6 checks passed
6 checks passed
api test Build finished. 431 tests run, 1 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 187 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 118 tests run, 5 skipped, 0 failed.
Details
selenium test Build finished. 146 tests run, 3 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
@mvdbeek

This comment has been minimized.

Copy link
Member

mvdbeek commented Oct 4, 2018

Merci from my 🇫🇷 coworkers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.