Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent double sanitizing history name when renaming #6871

Merged
merged 1 commit into from Oct 16, 2018

Conversation

Projects
None yet
3 participants
@almahmoud
Copy link
Contributor

commented Oct 15, 2018

This is intended to fix: galaxyproject/usegalaxy-playbook#169 / #6873

I was originally trying to "unescape" the name whenever it was displayed instead of removing the escape altogether, but given that names for workflows are only sanitized and not escaped, and that the history name is not escaped when changed from the panel on the right, I thought it might just be that it didn't need to be escaped in the first place.
If I am wrong and it does need to be escaped, let me know and I can instead try to convert it to its value whenever returned to the UI, while storing it escaped

@galaxybot galaxybot added the triage label Oct 15, 2018

@galaxybot galaxybot added this to the 19.01 milestone Oct 15, 2018

@martenson

This comment has been minimized.

Copy link
Member

commented Oct 16, 2018

Thanks @almahmoud !

@martenson martenson merged commit f4088c8 into galaxyproject:dev Oct 16, 2018

1 of 6 checks passed

api test Build finished. No test results found.
Details
framework test Build finished. No test results found.
Details
integration test Build finished. 123 tests run, 10 skipped, 1 failed.
Details
selenium test Build finished. No test results found.
Details
toolshed test Build finished. No test results found.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@martenson martenson changed the title History name not escaped prevent double sanitizing history name when renaming Oct 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.