Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use recently introduced overflow utility instead of overwriting card defaults #6948

Merged
merged 1 commit into from Oct 31, 2018

Conversation

Projects
None yet
2 participants
@guerler
Copy link
Contributor

commented Oct 30, 2018

This PR fixes admin related views e.g. Display Applications and the Whitelist by using the recently introduced BS4 overflow utility instead of overwriting card-style defaults. This is less invasive, restores the default and prevents the cropping of border shadows of elements which are placed close to the card body borders.

@guerler guerler added this to the 19.01 milestone Oct 30, 2018

@guerler guerler force-pushed the guerler:add_overflow_auto branch from b53526c to 6bd6fdb Oct 31, 2018

@guerler guerler added status/WIP and removed status/review labels Oct 31, 2018

@guerler guerler force-pushed the guerler:add_overflow_auto branch 3 times, most recently from 9279073 to 15f5f38 Oct 31, 2018

@guerler guerler force-pushed the guerler:add_overflow_auto branch from 15f5f38 to 20f3c04 Oct 31, 2018

@guerler guerler added status/review and removed status/WIP labels Oct 31, 2018

@guerler

This comment has been minimized.

Copy link
Contributor Author

commented Oct 31, 2018

There were no changes. I just resolved some merge conflicts.

@@ -24,19 +24,18 @@
transform: rotate(45deg);
}

// utility class from: https://github.com/twbs/bootstrap/pull/27268
.overflow-auto {

This comment has been minimized.

Copy link
@martenson

martenson Oct 31, 2018

Member

do we have to redefine the class given it was implemented in the PR mentioned above? https://github.com/twbs/bootstrap/pull/27268/files#diff-afd6c72eb64ef2c8a2d963958d6991d1R4

This comment has been minimized.

Copy link
@martenson

martenson Oct 31, 2018

Member

ah, it is unreleased yet, so I assume the plan is to remove it when they release

This comment has been minimized.

Copy link
@guerler

guerler Oct 31, 2018

Author Contributor

Its not in our version yet. It will be available with the next BS4 revision.

@martenson martenson merged commit 3f7425a into galaxyproject:dev Oct 31, 2018

0 of 6 checks passed

api test Build finished. No test results found.
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
toolshed test Build finished. No test results found.
Details
framework test Test started.
Details
integration test Test started.
Details
selenium test Test started.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.