Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sniffing of readname sorted BAM files #6950

Merged
merged 2 commits into from Oct 31, 2018

Conversation

Projects
None yet
3 participants
@mvdbeek
Copy link
Member

commented Oct 31, 2018

I'll backport the first commit after the merge, just want to exercise the new testing framework first.

The second commit contains test files I forgot to git add in #6869.

mvdbeek added some commits Oct 31, 2018

Fix sniffing of readname sorted BAM files
This fixes #6949.
The problem is that `super` would fall back to the BamInputSorted
sniffer, which prevents sniffing. Includes a test file for the new
datatype upload testing framework.

@galaxybot galaxybot added this to the 19.01 milestone Oct 31, 2018

@jmchilton jmchilton merged commit f40bb68 into galaxyproject:dev Oct 31, 2018

6 checks passed

api test Build finished. 435 tests run, 1 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 190 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 266 tests run, 10 skipped, 0 failed.
Details
selenium test Build finished. 147 tests run, 3 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.