Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression introduced in 6c82266546c77361f9d2265ab749db1446142150 . #701

Conversation

Projects
None yet
4 participants
@nsoranzo
Copy link
Member

commented Sep 7, 2015

Fix traceback when calling galaxy.webapps.galaxy.controllers.admin_toolshed.AdminToolshed.update_to_changeset_revision() due to repository being None.

Fix regression introduced in 6c82266 .
Fix traceback when calling galaxy.webapps.galaxy.controllers.admin_toolshed.AdminToolshed.update_to_changeset_revision()
due to repository being None.
@nsoranzo

This comment has been minimized.

Copy link
Member Author

commented Sep 7, 2015

This also fixes all 5 broken Tool Shed functional tests of run_tests.sh -toolshed

@bgruening

This comment has been minimized.

Copy link
Member

commented Sep 7, 2015

👍
Why aren't we running those tests in travis?

@nsoranzo

This comment has been minimized.

Copy link
Member Author

commented Sep 7, 2015

@dannon

This comment has been minimized.

Copy link
Member

commented Sep 8, 2015

+1

dannon added a commit that referenced this pull request Sep 8, 2015

Merge pull request #701 from nsoranzo/fix_for_6c82266546c77361f9d2265…
…ab749db1446142150

Fix regression introduced in 6c82266 .

@dannon dannon merged commit 26c79e4 into galaxyproject:dev Sep 8, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nsoranzo nsoranzo deleted the nsoranzo:fix_for_6c82266546c77361f9d2265ab749db1446142150 branch Sep 8, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.