Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass a ``JobWrapper`` instead of a ``Job`` to ``stop_job()`` methods #7023

Merged
merged 3 commits into from Nov 20, 2018

Conversation

Projects
None yet
2 participants
@nsoranzo
Copy link
Member

commented Nov 17, 2018

See #6912 (comment) .

Also:

  • Drop get_id() method of Job and Task classes
  • 2 small simplifications in JobWrapper class

nsoranzo added some commits Nov 16, 2018

2 small simplifications in ``JobWrapper``
After commit eeb1dae,
`JobWrapper.job_destination()` does not call
`self._job_dataset_path_rewriter()` any more.

@nsoranzo nsoranzo added this to the 19.01 milestone Nov 17, 2018

@jmchilton jmchilton merged commit 6778fa4 into galaxyproject:dev Nov 20, 2018

6 checks passed

api test Build finished. 442 tests run, 1 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 190 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 270 tests run, 10 skipped, 0 failed.
Details
selenium test Build finished. 151 tests run, 2 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details

@nsoranzo nsoranzo deleted the nsoranzo:stop_job_wrapper branch Nov 20, 2018

mvdbeek added a commit to mvdbeek/galaxy that referenced this pull request Feb 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.