Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.09] Fix set_peek method for copied datasets #7078

Merged

Conversation

Projects
None yet
3 participants
@mvdbeek
Copy link
Member

commented Dec 6, 2018

dataset_assoc is the job to ouptut dataset association that references
the HDA created by a job. If the HDA is copied the copies need to be
updated as well, so here we need to call set_peek on dataset, not
dataset_assoc.dataset.

Broken in f4343d8

Thanks for tracking this down @jmchilton!

Fix set_peek method for copied datasets
dataset_assoc is the job to ouptut dataset association that references
the HDA created by a job. If the HDA is copied the copies need to be
updated as well, so here we need to call `set_peek` on dataset, not
dataset_assoc.dataset.

Broken in f4343d8

Thanks for tracking this down @jmchilton!

@mvdbeek mvdbeek added this to the 19.01 milestone Dec 6, 2018

@jmchilton

This comment has been minimized.

Copy link
Member

commented Dec 11, 2018

Thanks for the fix, I hadn't noticed any errors surfacing from it but I was refactoring things in #7058 and noticed the incongruity - so this will break my refactoring when merged forward but is the right thing to do. Thanks for the fix @mvdbeek !

@martenson

This comment has been minimized.

Copy link
Member

commented Dec 11, 2018

the travis fail is probably same as #7035 (comment)

@martenson

This comment has been minimized.

Copy link
Member

commented Dec 11, 2018

@martenson martenson merged commit 7dd7d8a into galaxyproject:release_18.09 Dec 12, 2018

5 of 6 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
api test Build finished. 432 tests run, 1 skipped, 0 failed.
Details
framework test Build finished. 189 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 123 tests run, 10 skipped, 0 failed.
Details
selenium test Build finished. 146 tests run, 2 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.