Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-couple objectstore abstraction from XML. #7085

Merged
merged 1 commit into from Dec 12, 2018

Conversation

@jmchilton
Copy link
Member

jmchilton commented Dec 7, 2018

  • Allow loading objectstores for Python dicts and YAML configurations.
  • New tests for XML parsing of azure, cloud, pithos, and S3 object stores configs.
  • New tests for YAML parsing of all these object stores plus the vanilla disk and nested ones.

Sets up both loading object store configs right in Galaxy's galaxy.yml or Pulsar's app.yml as well as writing per-job object store configs out for #7050 so that jobs can know how to stage and unstage their own files on the potentially remote worker.

xref #7050 / #7058

- Allow loading objectstores for Python dicts and YAML configurations.
- New tests for XML parsing of azure, cloud, pithos, and S3 object stores.
- New tests for YAML parsing of all these object stores plus the stock disk and nested ones.
@jmchilton jmchilton force-pushed the jmchilton:objectstore_config branch from a045ff8 to ece11ea Dec 11, 2018
@jmchilton jmchilton modified the milestones: 19.01, 19.05 Dec 12, 2018
@jmchilton

This comment has been minimized.

Copy link
Member Author

jmchilton commented Dec 12, 2018

Delaying this to 19.05 but it is ready to go, if someone wants to be nice and merge it before the release is branched just move the tag back.

@erasche erasche modified the milestones: 19.05, 19.01 Dec 12, 2018
@erasche

This comment has been minimized.

Copy link
Member

erasche commented Dec 12, 2018

I'll do that @jmchilton :)

@erasche

This comment has been minimized.

Copy link
Member

erasche commented Dec 12, 2018

I'll try an add an XML test during the freeze period (that's what freezers are for, right?)

@erasche erasche merged commit 97564f1 into galaxyproject:dev Dec 12, 2018
6 checks passed
6 checks passed
api test Build finished. 444 tests run, 1 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 192 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 274 tests run, 10 skipped, 0 failed.
Details
selenium test Build finished. 151 tests run, 3 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
Remote Execution of Workflows/Jobs automation moved this from In progress to Done Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.