Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove collect_outputs_from option. #7144

Merged
merged 1 commit into from Jan 7, 2019

Conversation

4 participants
@jmchilton
Copy link
Member

commented Dec 20, 2018

And just disable dynamic discovery of outputs from new_file_path for legacy profile tools.

This is part of an ongoing effort to kill new_file_path and simplify output discovery.

This option was added by @natefoo 10 years ago and he switched main to disable new_file_path discovery and noone ever complained. So lets just do this for all Galaxies - if main hasn't run tools that require this functionality in a decade - I very much doubt any Galaxies require this.

@jmchilton jmchilton added this to In progress in Remote Execution of Workflows/Jobs via automation Dec 20, 2018

@galaxybot galaxybot added this to the 19.05 milestone Dec 20, 2018

@jmchilton jmchilton force-pushed the jmchilton:remove_collect_outputs_from branch from 18868ec to ae9f5f0 Dec 20, 2018

Remove collect_outputs_from option.
And just disable dynamic discovery of outputs from new_file_path for legacy profile tools.

This is part of an ongoing effort to kill new_file_path and simplify output discovery.

This option was added by @natefoo 10 years ago and he switched main to disable new_file_path discovery and noone ever complained. So lets just do this for all Galaxies - if main hasn't run tools that require this functionality in a decade - I very much doubt any Galaxies require this.

@jmchilton jmchilton force-pushed the jmchilton:remove_collect_outputs_from branch from ae9f5f0 to d91a666 Dec 20, 2018

@dannon

This comment has been minimized.

Copy link
Member

commented Dec 21, 2018

Sounds good to me. @natefoo?

@jmchilton jmchilton merged commit 681225b into galaxyproject:dev Jan 7, 2019

6 checks passed

api test Build finished. 444 tests run, 1 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 195 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 274 tests run, 10 skipped, 0 failed.
Details
selenium test Build finished. No test results found.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details

Remote Execution of Workflows/Jobs automation moved this from In progress to Done Jan 7, 2019

@nsoranzo nsoranzo deleted the jmchilton:remove_collect_outputs_from branch Jan 7, 2019

@natefoo

This comment has been minimized.

Copy link
Member

commented Feb 13, 2019

Belated +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.