Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up on handling connectable and collapsible parameters in workflows #7150

Merged
merged 8 commits into from Jan 2, 2019

Conversation

@guerler
Copy link
Contributor

guerler commented Dec 23, 2018

Connecting basic input parameters in the workflow editor is an awesome feature. Thanks a lot for adding it @jmchilton. This PR fixes a few remaining issues with the handling of connected and collapsible value options in the workflow editor. Currently connected values are not always updated after a click i.e. the terminal is not added to the module if the value was collapsed before. This required to re-click the option, to uncollapse and then re-trigger the connection request. This PR resolves this by fixing the refresh trigger and yielding priority to the connected option over the collapsible option i.e. if a parameter is connected it is connected regardless of it's prior collapsible state. Another addition ensures that only collapsible values can be connected. This avoids that e.g. data parameters are shown with a connectable option although they are always connected. Additionally, this PR fixes the tooltips which currently have two issues. They do not contain the correct text and they disappear after an option is selected. The latter being an issue of the BS4 update. Finally the pointer cursor is removed from the title text since it is not clickable anymore and margins are added between the option icons.

@guerler guerler changed the title Follow-up on handling connectable and collapsible parameter in workflows Follow-up on handling connectable and collapsible parameters in workflows Dec 23, 2018
@guerler guerler requested a review from jmchilton Dec 23, 2018
@guerler guerler added status/review and removed status/WIP labels Dec 23, 2018
@galaxybot galaxybot added this to the 19.05 milestone Dec 23, 2018
@jmchilton jmchilton modified the milestones: 19.05, 19.01 Dec 24, 2018
@jmchilton jmchilton merged commit a8944f5 into galaxyproject:dev Jan 2, 2019
6 checks passed
6 checks passed
api test Build finished. 444 tests run, 1 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 195 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 275 tests run, 10 skipped, 0 failed.
Details
selenium test Build finished. 151 tests run, 2 skipped, 0 failed.
Details
toolshed test Build finished. 577 tests run, 0 skipped, 0 failed.
Details
@jmchilton

This comment has been minimized.

Copy link
Member

jmchilton commented Jan 2, 2019

Wonderful - thanks for fixing up my mess @guerler - sorry for not getting to it sooner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.