Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error listener for input elements #7183

Merged
merged 8 commits into from Jan 17, 2019

Conversation

Projects
None yet
2 participants
@guerler
Copy link
Contributor

commented Jan 7, 2019

This PR adds an error listener for input elements, allowing them to individually trigger custom errors or warnings. Warning messages have been added to the slider element to highlight out-of-range inputs. This fixes #7172. This feature can be re-used in #6321.

@mvdbeek

This comment has been minimized.

Copy link
Member

commented Jan 16, 2019

Is this ready for review @guerler ?

@guerler guerler added status/review and removed status/WIP labels Jan 16, 2019

@mvdbeek
Copy link
Member

left a comment

Works well, thanks @guerler!

@mvdbeek mvdbeek changed the base branch from dev to release_19.01 Jan 17, 2019

@mvdbeek mvdbeek changed the base branch from release_19.01 to dev Jan 17, 2019

@mvdbeek mvdbeek merged commit f2ccea2 into galaxyproject:dev Jan 17, 2019

1 of 6 checks passed

api test Test started.
Details
framework test Test started.
Details
integration test Test started.
Details
selenium test Test started.
Details
toolshed test Test started.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

dannon added a commit that referenced this pull request Jan 17, 2019

Merge pull request #7229 from mvdbeek/backport_sliding_validator
[19.01] Backport #7183 input element listener
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.