Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use regular font-size and styling in uploader #7232

Merged
merged 12 commits into from Jan 18, 2019

Conversation

Projects
None yet
3 participants
@guerler
Copy link
Contributor

commented Jan 17, 2019

In some cases the font-sizes used in the upload view are too small compared to the rest of the UI. Additionally there are some inconsistent element dimensions. This PR increases the font-sizes to regular. It aligns the style of the upload view, reduces style customizations and refactors the template strings using ES6 literals.

untitled

@guerler guerler added status/review and removed status/WIP labels Jan 17, 2019

@dannon

This comment has been minimized.

Copy link
Member

commented Jan 18, 2019

Here are the two side by side for comparison.

before:
image

after:
image

@dannon dannon self-assigned this Jan 18, 2019

Apply suggestions from code review
Co-Authored-By: dannon <dannon.baker@gmail.com>
@guerler

This comment has been minimized.

Copy link
Contributor Author

commented Jan 18, 2019

Thanks @nsoranzo.

@dannon

This comment has been minimized.

Copy link
Member

commented Jan 18, 2019

@guerler I merged nsoranzo's suggestions in because I'd planned on merging the whole thing, but I'm tinkering with some padding options for .upload-top-info prior to that. The text seems close to the line, but I don't like how options I'm coming up with work with the whitespace when there's nothing there, so far.

dannon added some commits Jan 18, 2019

Leave a block element in upload-top-info for consistent spacing. The …
…other three tabs already start with info there.
@dannon

This comment has been minimized.

Copy link
Member

commented Jan 18, 2019

@guerler Finally got back to tweaking the text, look good to you?

image

(so it's all vertically centered with flexible padding that should scale with text size changes)

@guerler

This comment has been minimized.

Copy link
Contributor Author

commented Jan 18, 2019

Looks good. Thanks!

@dannon

This comment has been minimized.

Copy link
Member

commented Jan 18, 2019

@guerler Cool. Thanks for the fixes!

@dannon dannon merged commit ce113af into galaxyproject:dev Jan 18, 2019

0 of 6 checks passed

api test Test started.
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
framework test Test started.
Details
integration test Test started.
Details
selenium test Test started.
Details
toolshed test Test started.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.