Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use es6 literal for library toolbar header, use icon buttons, left align #7234

Merged
merged 6 commits into from Feb 6, 2019

Conversation

Projects
None yet
3 participants
@guerler
Copy link
Contributor

commented Jan 17, 2019

Suggestion for library toolbar header appearance.

@guerler guerler added this to the 19.05 milestone Jan 17, 2019

@guerler guerler requested a review from martenson Jan 17, 2019

@martenson

This comment has been minimized.

Copy link
Member

commented Jan 17, 2019

looks nice, we can merge as is if you want

@guerler

This comment has been minimized.

Copy link
Contributor Author

commented Jan 17, 2019

I followed-up by adjusting the folder toolbar too.

guerler added some commits Jan 17, 2019

@guerler guerler added status/review and removed status/WIP labels Feb 5, 2019

@martenson
Copy link
Member

left a comment

works well, thanks for the pretty formatting too!

@martenson martenson merged commit 415444d into galaxyproject:dev Feb 6, 2019

5 of 6 checks passed

selenium test Build finished. 151 tests run, 4 skipped, 1 failed.
Details
api test Build finished. 449 tests run, 1 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 195 tests run, 0 skipped, 0 failed.
Details
integration test Build finished. 285 tests run, 12 skipped, 0 failed.
Details
toolshed test Build finished. 578 tests run, 0 skipped, 0 failed.
Details
@nsoranzo

This comment has been minimized.

Copy link
Member

commented Feb 7, 2019

The culprit seems to be commit 8702d67 , according to git bisect.

@guerler

This comment has been minimized.

Copy link
Contributor Author

commented Feb 7, 2019

Thanks @nsoranzo. I'll check it out.

@guerler

This comment has been minimized.

Copy link
Contributor Author

commented Feb 7, 2019

@nsoranzo #7321 fixes this.

martenson added a commit to martenson/galaxy that referenced this pull request Feb 8, 2019

martenson added a commit to martenson/galaxy that referenced this pull request Feb 8, 2019

@martenson martenson referenced this pull request Feb 8, 2019

Merged

ui fixes to datalibs #7337

@guerler guerler referenced this pull request Apr 17, 2019

Closed

Fix Look and Feel in Dataset Libraries #7764

0 of 7 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.